Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #6064

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

systay
Copy link
Collaborator

@systay systay commented Apr 14, 2020

No description provided.

Signed-off-by: Andres Taylor <[email protected]>
@systay systay requested a review from sougou as a code owner April 14, 2020 06:03
@systay systay requested a review from harshit-gangal April 14, 2020 06:04
@harshit-gangal
Copy link
Member

There are lot of places to remove MarshalJson code. :)

@systay
Copy link
Collaborator Author

systay commented Apr 14, 2020

We recently moved JSON marshalling of primitives to PrimitiveDescription. That is what I'm trying to clean up here. Not sure what you JSON marshalling you are thinking about.

@harshit-gangal
Copy link
Member

We recently moved JSON marshalling of primitives to PrimitiveDescription. That is what I'm trying to clean up here. Not sure what you JSON marshalling you are thinking about.

This needs to be removed from all the primitive. I meant you have removed from 4 primitives only.

@harshit-gangal harshit-gangal merged commit 5f3c4b7 into vitessio:master Apr 14, 2020
@harshit-gangal harshit-gangal deleted the at-remove-marshaljson branch April 14, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants